Skip to content

Types: Emulate PostgreSQL's JSON(B) types using CrateDB's OBJECT#27

Merged
bgunebakan merged 4 commits into
mainfrom
amo/type-json-jsonb
Jun 12, 2026
Merged

Types: Emulate PostgreSQL's JSON(B) types using CrateDB's OBJECT#27
bgunebakan merged 4 commits into
mainfrom
amo/type-json-jsonb

Conversation

@amotl

@amotl amotl commented Jan 16, 2024 •
edited by florinutz
Loading

Copy link
Copy Markdown
Contributor

About

The test suite of meltano-tap-cratedb, derived from the corresponding PostgreSQL adapter, is using PostgreSQL's JSON and JSONB types. By emulating them using CrateDB's OBJECT type, the corresponding test cases succeed without further ado. 💯

References

This is coming from a monkeypatch to meltano-tap-cratedb.

closes #215

@amotl amotl mentioned this pull request Jun 17, 2024
Open
@amotl amotl force-pushed the amo/type-json-jsonb branch 2 times, most recently from bda9012 to 70549f0 Compare June 25, 2024 14:55
@amotl amotl mentioned this pull request Dec 12, 2024
Merged
@amotl amotl force-pushed the amo/type-json-jsonb branch from 70549f0 to 90c742c Compare March 30, 2025 02:28
@amotl amotl mentioned this pull request Mar 30, 2025
Closed
@amotl amotl force-pushed the amo/type-json-jsonb branch from 90c742c to 02a43e4 Compare June 2, 2026 20:52
@coderabbitai

coderabbitai Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e4a7afcf-1040-4a8c-b552-36e098bdc65a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch amo/type-json-jsonb

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@amotl amotl force-pushed the amo/type-json-jsonb branch 3 times, most recently from c286548 to bdb92ab Compare June 2, 2026 22:21
@amotl amotl requested a review from bgunebakan June 2, 2026 22:37
@amotl amotl marked this pull request as ready for review June 2, 2026 22:37
@amotl amotl requested a review from kneth June 3, 2026 10:02
kneth
kneth reviewed Jun 4, 2026
View reviewed changes
Comment thread tests/compiler_test.py
@amotl amotl force-pushed the amo/type-json-jsonb branch from bdb92ab to 7c0acd3 Compare June 4, 2026 22:30
@amotl amotl requested a review from kneth June 4, 2026 22:38
@coderabbitai coderabbitai Bot mentioned this pull request Jun 4, 2026
Open
2 tasks
kneth
kneth approved these changes Jun 8, 2026
View reviewed changes

@kneth kneth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the created issue for later, I say it LGTM

@amotl

amotl commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for acknowledging. Please merge at your disposal, I've currently lost relevant capabilities.

bgunebakan
bgunebakan requested changes Jun 12, 2026
View reviewed changes

@bgunebakan bgunebakan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good, there is just small comments.

Comment thread tests/compiler_test.py
Comment thread tests/compiler_test.py Outdated
@amotl

amotl commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Hi @bgunebakan. Thank you for looking into this. Please take over and add missing bits at your disposal. Thank you!

@bgunebakan bgunebakan merged commit 6d78dc4 into main Jun 12, 2026
36 of 37 checks passed
@bgunebakan bgunebakan deleted the amo/type-json-jsonb branch June 12, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@kneth kneth kneth approved these changes

@bgunebakan bgunebakan bgunebakan approved these changes

Assignees

@bgunebakan bgunebakan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amotl @kneth @bgunebakan